Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md: Add section about automatic testing and draft PRs #9882

Merged
merged 3 commits into from Jun 20, 2023
Merged

CONTRIBUTING.md: Add section about automatic testing and draft PRs #9882

merged 3 commits into from Jun 20, 2023

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Jun 9, 2023 •
edited

What this PR does / why we need it:

Add section about automated testing and draft pull requests to the CONTRIBUTING.md doc.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This PR is ready for review, it's marked as draft, since the change is entirely markdown and CI signal is not needed.!

/cc @fabiand @brianmcarey @xpivarc

Release note:

Add some context for initial contributors about automated testing and draft pull requests.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 9, 2023
@kubevirt-bot kubevirt-bot requested a review from fabiand June 9, 2023 08:37
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2023
@kubevirt-bot kubevirt-bot requested a review from xpivarc June 9, 2023 08:37
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jun 9, 2023
@dhiller dhiller force-pushed the add-contributing-draft-prs branch 2 times, most recently from 7079758 to 9347b24 Compare June 9, 2023 11:11
@dhiller
Add section about automatic testing and draft PRs
3e5dd02 
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller dhiller force-pushed the add-contributing-draft-prs branch from 9347b24 to 3e5dd02 Compare June 9, 2023 11:17
@dhiller
Copy link
Contributor Author

dhiller commented Jun 9, 2023

@aburdenthehand would really appreciate you proofreading this if you have time. Thank you!

aburdenthehand
aburdenthehand reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhiller This is really nice to see!
I have made some suggestions with some of the wording. Please let me know if I've changed your intended meaning anywhere (or if you disagree!).

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@dhiller @aburdenthehand
Apply suggestions from code review
5df6ec3 
Co-authored-by: aburdenthehand <aburden@redhat.com>
Signed-off-by: Daniel Hiller <daniel.hiller.1972@googlemail.com>
@dhiller
Copy link
Contributor Author

dhiller commented Jun 12, 2023

@dhiller This is really nice to see! I have made some suggestions with some of the wording. Please let me know if I've changed your intended meaning anywhere (or if you disagree!).

Thank you Andrew! Very much appreciated!

@dhiller dhiller marked this pull request as ready for review June 13, 2023 11:25
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
brianmcarey
brianmcarey reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

One tiny nit comment - but feel free to continue as is.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@dhiller @brianmcarey
Apply suggestions from code review
5d2a121 
Co-authored-by: Brian Carey <bcarey@redhat.com>
Signed-off-by: Daniel Hiller <daniel.hiller.1972@googlemail.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@dhiller
Copy link
Contributor Author

dhiller commented Jun 19, 2023

/lgtm

One tiny nit comment - but feel free to continue as is.

Thanks @brianmcarey! Updated, PTAL.

brianmcarey
brianmcarey reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @dhiller

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jun 19, 2023 •
edited

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-metrics-lint 3e5dd02 link unknown /test pull-kubevirt-metrics-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhiller
Copy link
Contributor Author

dhiller commented Jun 20, 2023

/override pull-kubevirt-metrics-lint

Unrelated.

@kubevirt-bot
Copy link
Contributor

@dhiller: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • pull-kubevirt-metrics-lint

Only the following failed contexts/checkruns were expected:

  • dco
  • pull-kubevirt-apidocs
  • pull-kubevirt-apidocs-0.34
  • pull-kubevirt-build
  • pull-kubevirt-build-0.36
  • pull-kubevirt-build-arm64
  • pull-kubevirt-build-arm64-0.41
  • pull-kubevirt-check-tests-for-flakes
  • pull-kubevirt-check-tests-for-flakes-0.30
  • pull-kubevirt-check-unassigned-tests
  • pull-kubevirt-check-unassigned-tests-0.43
  • pull-kubevirt-client-python
  • pull-kubevirt-client-python-0.34
  • pull-kubevirt-code-lint
  • pull-kubevirt-code-lint-0.55
  • pull-kubevirt-e2e-k8s-1.25-ipv6-sig-network
  • pull-kubevirt-e2e-k8s-1.25-ipv6-sig-network-0.59
  • pull-kubevirt-e2e-k8s-1.25-sig-compute
  • pull-kubevirt-e2e-k8s-1.25-sig-compute-0.59
  • pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations
  • pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations-0.59
  • pull-kubevirt-e2e-k8s-1.25-sig-network
  • pull-kubevirt-e2e-k8s-1.25-sig-network-0.59
  • pull-kubevirt-e2e-k8s-1.25-sig-operator
  • pull-kubevirt-e2e-k8s-1.25-sig-operator-0.59
  • pull-kubevirt-e2e-k8s-1.25-sig-storage
  • pull-kubevirt-e2e-k8s-1.25-sig-storage-0.59
  • pull-kubevirt-e2e-k8s-1.26-sig-compute
  • pull-kubevirt-e2e-k8s-1.26-sig-compute-0.59
  • pull-kubevirt-e2e-k8s-1.26-sig-network
  • pull-kubevirt-e2e-k8s-1.26-sig-network-0.59
  • pull-kubevirt-e2e-k8s-1.26-sig-operator
  • pull-kubevirt-e2e-k8s-1.26-sig-operator-1.0
  • pull-kubevirt-e2e-k8s-1.26-sig-storage
  • pull-kubevirt-e2e-k8s-1.26-sig-storage-0.59
  • pull-kubevirt-e2e-k8s-1.27-sig-compute
  • pull-kubevirt-e2e-k8s-1.27-sig-compute-1.0
  • pull-kubevirt-e2e-k8s-1.27-sig-network
  • pull-kubevirt-e2e-k8s-1.27-sig-network-1.0
  • pull-kubevirt-e2e-k8s-1.27-sig-operator
  • pull-kubevirt-e2e-k8s-1.27-sig-operator-1.0
  • pull-kubevirt-e2e-k8s-1.27-sig-storage
  • pull-kubevirt-e2e-k8s-1.27-sig-storage-1.0
  • pull-kubevirt-e2e-kind-1.27-sriov
  • pull-kubevirt-e2e-kind-1.27-sriov-1.0
  • pull-kubevirt-e2e-kind-1.27-vgpu
  • pull-kubevirt-e2e-windows2016
  • pull-kubevirt-e2e-windows2016-0.13
  • pull-kubevirt-generate
  • pull-kubevirt-generate-0.34
  • pull-kubevirt-goveralls
  • pull-kubevirt-goveralls-0.34
  • pull-kubevirt-manifests
  • pull-kubevirt-manifests-0.34
  • pull-kubevirt-prom-rules-verify
  • pull-kubevirt-prom-rules-verify-0.34
  • pull-kubevirt-unit-test
  • pull-kubevirt-unit-test-0.34
  • pull-kubevirt-unit-test-arm64
  • pull-kubevirt-unit-test-arm64-0.59
  • pull-kubevirt-verify-go-mod
  • pull-kubevirt-verify-go-mod-0.44
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override pull-kubevirt-metrics-lint

Unrelated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xpivarc
xpivarc reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@kubevirt-bot kubevirt-bot merged commit 7fc18df into kubevirt:main Jun 20, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey left review comments

@xpivarc xpivarc xpivarc left review comments

@fabiand fabiand Awaiting requested review from fabiand

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dhiller @kubevirt-bot @aburdenthehand @brianmcarey @xpivarc