Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sevctl to the test image #9892

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

vasiliy-ul
Copy link
Contributor

@vasiliy-ul vasiliy-ul commented Jun 12, 2023

What this PR does / why we need it:

The PR adds sevctl tool to the test image. This is needed for e2e testing of the SEV attestation APIs #7197.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

I decided to decouple that part from the attestation PR #7197, so it can be reviewed and merged independently as a smaller chunk.

Had to bump edk2 and libvirt as well:

  • current edk2 rpm is not available anymore in the repos
  • libvirt conflicts with the new edk2

UPD: not picking the latest available edk2 since it will also require a bump of libvirt.

Release note:

NONE

Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jun 12, 2023
The previously used version of edk2 is not available in the repositories
anymore.

Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
This will pick sevctl and newer edk2.

Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
@vasiliy-ul
Copy link
Contributor Author

As discussed with @andreabolognani in Slack: not picking the latest available edk2 since it will also require a bump of libvirt.

@vasiliy-ul
Copy link
Contributor Author

/test pull-kubevirt-e2e-k8s-1.26-sev

@vasiliy-ul
Copy link
Contributor Author

/test pull-kubevirt-e2e-k8s-1.27-sig-storage

@vasiliy-ul
Copy link
Contributor Author

/retest-required

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jun 12, 2023

@vasiliy-ul: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-code-lint bed4339 link false /test pull-kubevirt-code-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vasiliy-ul
Copy link
Contributor Author

/test pull-kubevirt-e2e-k8s-1.27-sig-compute

@vasiliy-ul
Copy link
Contributor Author

@alicefr, @iholder101, @xpivarc, @rmohr, @andreabolognani, I decoupled this small change from the SEV PR. Just to make it a bit easier for review in smaller chunks. Would appreciate if you could take a look when have some time and lgtm/approve. Thanks!

@rmohr
Copy link
Member

rmohr commented Jun 13, 2023

/lgtm
/approve

looks great.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@iholder101
Copy link
Contributor

Thank you @vasiliy-ul!
/lgtm

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 5dfcf13 into kubevirt:main Jun 13, 2023
36 of 37 checks passed
@vasiliy-ul vasiliy-ul deleted the add-sevctl branch June 14, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants