-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sevctl to the test image #9892
Conversation
Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
The previously used version of edk2 is not available in the repositories anymore. Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
This will pick sevctl and newer edk2. Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
As discussed with @andreabolognani in Slack: not picking the latest available edk2 since it will also require a bump of libvirt. |
/test pull-kubevirt-e2e-k8s-1.26-sev |
/test pull-kubevirt-e2e-k8s-1.27-sig-storage |
/retest-required |
@vasiliy-ul: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubevirt-e2e-k8s-1.27-sig-compute |
@alicefr, @iholder101, @xpivarc, @rmohr, @andreabolognani, I decoupled this small change from the SEV PR. Just to make it a bit easier for review in smaller chunks. Would appreciate if you could take a look when have some time and lgtm/approve. Thanks! |
/lgtm looks great. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @vasiliy-ul! |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
What this PR does / why we need it:
The PR adds
sevctl
tool to the test image. This is needed for e2e testing of the SEV attestation APIs #7197.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
I decided to decouple that part from the attestation PR #7197, so it can be reviewed and merged independently as a smaller chunk.
Had to bump edk2
and libvirtas well:libvirt conflicts with the new edk2UPD: not picking the latest available edk2 since it will also require a bump of libvirt.
Release note: