Fix for hotplug with WFFC and CDI populators + test fixes #9918
Conversation
When dv uses cdi populators it doesn't need a doppelganger pod for wffc storage class it can be attached and then it will get populated. Fix missing condition in case dv phase is pendingPopulation you can trigger the attachment pod. Signed-off-by: Shelly Kagan <skagan@redhat.com>
When having WFFC storage class if this is a sci storage class cdi populators will be used and dv will have new phase: PendingPopulation, expect the phase to be either WFFC or that. Signed-off-by: Shelly Kagan <skagan@redhat.com>
kubevirt-bot
added
release-note
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-1.0 |
|
@mhenriks: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mhenriks: new pull request created: #9931 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
When Kubevirt will run with newer version of CDI with integration of data volumes and CDI populators DV with WFFC SCI storage class will have new phase pendingPopulation, when hotpluging a dv with this phase we can continue to create the attachment pod and it will trigger the population.
This PR fixes the check if a dv is ready to be attached.
Also adjusting some tests to take into account either WFFC phase or PendingPopulation phase.
Release note: