[virt-operator]: always deploy the outdated VMI workload alert #9988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
the motivation is to eliminate redundant kubevirt deployment calculations and re-deployment. The alternative to this approach is to inject/remove the alert in virt-operator reconciler logic but I think it will add a boiler-plate code. Signed-off-by: enp0s3 <ibezukh@redhat.com>
enp0s3
force-pushed
the
workload-updater-monitoring
branch
from
3cb24b0
to
61a98f1
Compare
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
/retest-required |
|
/cc @vladikr |
|
/retest-required |
|
/cc |
|
/cc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: enp0s3 ibezukh@redhat.com
I don't see any harm in permanent deployment of that alert. The evaluation of
kubevirt_vmi_outdated_count != 0will remain false even the metric is stale, so I don't see any risk of false positives here.
What this PR does / why we need it:
In the current situation if we configure a workload update method in the Kubevirt CR it will
cause re-deployment of all the virt-components. That is because adding a method will populate the
additionalPropertiesmap, which in turn cause changes in kubevirt deployment config digest.We can change the logic and to inject the alert in the virt-operator sync loop in the reconciler, but
I think it is a redundant considering the fact the deployment of this alert anyway won't cause any
harm.
Release note: