option added to set docker daemon proxy setting

[kunalkushwaha]

--docker-proxy option added to gocli run command.
This helps to set proxy setting for docker daemon
without rebuilding of base VM image.

Fixes #69 along with #71

Signed-off-by: Kunal Kushwaha kushwaha_kunal_v7@lab.ntt.co.jp

[kubevirt-bot]

Hi @kunalkushwaha. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kunalkushwaha]

This PR enables to overwrite provision scripts while starting k8s cluster, which is helpful in settings like docker daemon proxy settings, downloading networking [podnetwork].yaml in kubectl apply command etc
e.g.

$ ./cli run --mount-scripts /home/kunal/kubevirtci/k8s/scripts --nodes 1 --memory 5120M --cpu 5 --random-ports  --background --prefix k8s-1.10.11 --registry-volume
kubevirt_registry kubevirtci/k8s-1.10.11@sha256:b97e556795a56b9aa1763ddf3a49322b49f96877dccb7a164bbca779df078536 --ocp-port 8443

[rmohr]

Avoids rebuilding of base VM image for every change in environment.

We deliberately want to rebuild the VM image. The trick is that all docker images are already cached and all rpms preinstalled. There seems to be only the issue that it fetches the flannel manifests from the internet again, that is why kubectl apply fails.

I am not against the content of this PR, we can add it, but it is not a fix for #69. We should not fetch manifests from the internet again on cluster-up.

[kunalkushwaha]

Updated the PR for scope limited to docker daemon proxy settings as discussed in #69 (comment)

Along with #71 this will make cluster workable behind proxy.

//cc @rmohr

[rmohr]

/test check-provision-k8s-1.10.11
/test check-provision-k8s-1.11.0
/test check-provision-k8s-1.13.3
/test check-provision-k8s-multus-1.12.2
/test check-provision-k8s-multus-1.13.3
/test check-provision-k8s-genie-1.11.1

[rmohr]

oh, we need gocli test runs ...

[kunalkushwaha]

/test push-gocli

[kubevirt-bot]

@kunalkushwaha: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[slintes]

/ok-to-test
/test push-gocli

[kunalkushwaha]

/retest

[rmohr]

/test push-gocli

[rmohr]

/test check-gocli

[rmohr]

@kunalkushwaha @slintes, sorry for the confusion, but the jobs were not actually active so far, I manually triggered them. Should work now. Let's see what the results say.

[rmohr]

@kunalkushwaha can you add the new gocli digest to the README.md? The digest from the job is sha256:837ab7fff4e00d74ad9d6b8952c79dbf3df1db380da1fc13a87df34d70745003. After that the PR can be merged.

[rmohr]

/hold

digest needs to be updated.

[rmohr]

/lgtm
/approve

[kunalkushwaha]

The digest from the job is sha256:837ab7fff4e00d74ad9d6b8952c79dbf3df1db380da1fc13a87df34d70745003. After that the PR can be merged.

@rmohr thanks. I have updated README.md with suggested digest.

[rmohr]

/test check-gocli

[rmohr]

/hold cancel
/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rmohr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment