New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monitoring linter #221
Conversation
a53ab94
to
0cde6e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did preliminary quick review. Added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit, otherwise good progress so far!
0cde6e3
to
c1af868
Compare
f979aef
to
d7d196e
Compare
although this is a package that executes testing, it is nonetheless a package to be distributed/imported by other projects
code in wdyt @nunnatsa? |
It should not be in (and by the way, "monitoringlocationlinter" limit you to only check locations. What if you'll want to add additional rules?) WDYT about this?
|
yes, new directory named |
89cca74
to
a2911dd
Compare
a2911dd
to
738a838
Compare
Hi @nunnatsa, @machadovilaca, can you please review again?
|
803b2d7
to
5568c13
Compare
Signed-off-by: assafad <aadmi@redhat.com>
5568c13
to
b631af8
Compare
/lgtm |
What this PR does / why we need it:
Monitoring Linter is a Golang linter designed to ensure that in Kubernetes operator projects,
monitoring-related practices are implemented within the
pkg/monitoring
directory using operator-observability methods. It verifies that all metrics, alerts and recording rules registrations are centralized in this directory.The use of Prometheus registration methods is restricted across the entire project.
Fixes https://issues.redhat.com/browse/CNV-36760.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: