Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runbook for VMCannotBeEvicted #6

Merged
merged 4 commits into from Apr 26, 2021

Conversation

ezrasilvera
Copy link
Contributor

Signed-off-by: Ezra Silvera ezra@il.ibm.com

VMCannotBeEvicted is generated when the eviction strategy of a VM is set to "Live Migration" but the VM is not migratable.
The PR to generate the Prometheus metrics and alert is in kubevirt/kubevirt#5392

Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
Copy link
Member

@stu-gott stu-gott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. a few minor changes might be in order.

runbooks/VMCannotBeEvicted.md Outdated Show resolved Hide resolved
runbooks/VMCannotBeEvicted.md Outdated Show resolved Hide resolved
Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
Copy link
Member

@stu-gott stu-gott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so close!

runbooks/VMCannotBeEvicted.md Outdated Show resolved Hide resolved
runbooks/VMCannotBeEvicted.md Outdated Show resolved Hide resolved
Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 26, 2021
Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 26, 2021
@sradco sradco merged commit e36828a into kubevirt:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants