Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the missing run permissions to the gather_instancetypes script #160

Merged
merged 1 commit into from Nov 16, 2022
Merged

add the missing run permissions to the gather_instancetypes script #160

merged 1 commit into from Nov 16, 2022

Conversation

nunnatsa
Copy link
Collaborator

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Release note:

fix bug: add the missing run permmisions to the gather_instancetypes script

@nunnatsa
add the missing run permmisions to the gather_instancetypes script
2560939 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orenc1 orenc1 changed the title add the missing run permmisions to the gather_instancetypes script add the missing run permissions to the gather_instancetypes script Nov 15, 2022
@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@machadovilaca
Copy link
Member

maybe in the future we can add a test for this

@nunnatsa
Copy link
Collaborator Author

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa nunnatsa mentioned this pull request Nov 16, 2022
Closed
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

GCP lane passed

/override ci/prow/kubevirt-must-gather-e2e-azure

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/kubevirt-must-gather-e2e-azure

In response to this:

GCP lane passed

/override ci/prow/kubevirt-must-gather-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit a0546e0 into kubevirt:main Nov 16, 2022
@kubevirt-bot
Copy link

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/kubevirt-must-gather-e2e-azure

In response to this:

GCP lane passed

/override ci/prow/kubevirt-must-gather-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa deleted the fix-gather_instancetypes branch November 16, 2022 15:36
@nunnatsa
Copy link
Collaborator Author

/cherry-pick release-4.11

@openshift-cherrypick-robot
Copy link

@nunnatsa: only kubevirt org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Nov 17, 2022
Merged
@kubevirt-bot
Copy link

@nunnatsa: new pull request created: #163

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nunnatsa @kubevirt-bot @machadovilaca @openshift-cherrypick-robot