Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Collect VM data from completed virt-launcher pods #181

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Don't Collect VM data from completed virt-launcher pods #181

merged 1 commit into from
Jul 11, 2023

Conversation

nijinashok
Copy link
Contributor

@nijinashok nijinashok commented Jun 8, 2023 •
edited

If the VMs are live migrated, there will be source virt-launcher pods with status "completed". So oc exec will fail on these pods with error "cannot exec into a container in a completed pod". This results in many empty files under vms/<vm-name> if the VM was migrated multiple times. So run gather_vm_info only for "running" pods.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=2216447

Release note:

Collect VM data only from running virt-launcher pods

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 8, 2023
@openshift-ci openshift-ci bot requested review from sradco and tiraboschi June 8, 2023 13:23
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

Hi @nijinashok. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machadovilaca
Copy link
Member

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2023
@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023
@nijinashok
Don't Collect VM data from completed virt-launcher pods
f6fa89e 
If the VMs are live migrated, there will be source virt-launcher pods
with status "completed". So oc exec will fail on these pods with error
"cannot exec into a container in a completed pod". This results in many
empty files under vms/<vm-name> if the VM was migrated multiple times.
So don't run run gather_vm_info on completed virt-launcher pods.

Signed-off-by: Nijin Ashok <nashok@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@kubevirt-bot
Copy link

New changes are detected. LGTM label has been removed.

@nijinashok nijinashok changed the title Collect VM data only from running virt-launcher pods Don't Collect VM data from completed virt-launcher pods Jul 11, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2023
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nijinashok, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 88be2a1 into kubevirt:main Jul 11, 2023
6 checks passed
@nijinashok nijinashok deleted the running_vms branch July 12, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@sradco sradco Awaiting requested review from sradco

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

Assignees

@tiraboschi tiraboschi

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nijinashok @machadovilaca @kubevirt-bot @tiraboschi