Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targeted gathering to collect VM information #96

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

nunnatsa
Copy link
Collaborator

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Release note:

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 10, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2021
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nunnatsa
Copy link
Collaborator Author

/test kubevirt-must-gather-e2e-azure

@kubevirt-bot
Copy link

@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main

In response to this:

/test kubevirt-must-gather-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/hold

First, we'll build some stabilization branches

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2021
@masayag
Copy link
Contributor

masayag commented Oct 11, 2021

@nunnatsa what do you think of collecting node-gather data for the node on which the VM is running (or failed to run) ?

@nunnatsa
Copy link
Collaborator Author

@nunnatsa what do you think of collecting node-gather data for the node on which the VM is running (or failed to run) ?

We need to do that carefully. We removed this some time ago from the default kubevirt-gathering, sine kubelet logs are huge, and collecting node info is supported in the openshift's must-gather.

@masayag
Copy link
Contributor

masayag commented Oct 11, 2021

@nunnatsa what do you think of collecting node-gather data for the node on which the VM is running (or failed to run) ?

We need to do that carefully. We removed this some time ago from the default kubevirt-gathering, sine kubelet logs are huge, and collecting node info is supported in the openshift's must-gather.

I'm referring to gather_nodes, but in this context only for the node related to the vm, not for all of the nodes.

If it doesn't bring any value to debugging single vm failure, then ignore it.

@nunnatsa
Copy link
Collaborator Author

I'm referring to gather_nodes, but in this context only for the node related to the vm, not for all of the nodes.

If it doesn't bring any value to debugging single vm failure, then ignore it.

Maybe we can read a specific node as a targeted gathering, but not as part of this PR.

@nunnatsa
Copy link
Collaborator Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2021
@nunnatsa nunnatsa force-pushed the add-targeted branch 2 times, most recently from 8519cdb to d6cb3eb Compare October 14, 2021 08:29
README.md Outdated Show resolved Hide resolved
Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nunnatsa,tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@tiraboschi
Copy link
Member

/approved

@nunnatsa
Copy link
Collaborator Author

/test kubevirt-must-gather-e2e-azure

@kubevirt-bot
Copy link

@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main

In response to this:

/test kubevirt-must-gather-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/test kubevirt-must-gather-e2e-azure

@kubevirt-bot
Copy link

@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main

In response to this:

/test kubevirt-must-gather-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit dc8d6b0 into kubevirt:main Oct 14, 2021
@nunnatsa nunnatsa deleted the add-targeted branch October 17, 2021 13:30
nunnatsa added a commit to nunnatsa/must-gather that referenced this pull request Oct 21, 2021
…irt#96 and kubevirt#97)

Add targeted gathering to collect VM information (kubevirt#96)

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

When running tasks in parallel, it is now possible to overide the default number of processes of 5, by setting the `PROS` environment variable.

In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable.

Drop the gather_images from the default gathering. It can be still called explicitly.

Split the namespaces out of the main script to avoif using `--all-namespaces` to inscpect namespaces.

Remove many duplications.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
nunnatsa added a commit to nunnatsa/must-gather that referenced this pull request Oct 21, 2021
…irt#96 and kubevirt#97)

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable.

In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable.

Drop the gather_images from the default gathering. It can be still called explicitly.

Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces.

Remove many duplications.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
nunnatsa added a commit to nunnatsa/must-gather that referenced this pull request Oct 21, 2021
…irt#96 and kubevirt#97)

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable.

In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable.

Drop the gather_images from the default gathering. It can be still called explicitly.

Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces.

Remove many duplications.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Nov 4, 2021
#97) (#100)

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable.

In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable.

Drop the gather_images from the default gathering. It can be still called explicitly.

Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces.

Remove many duplications.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Nov 4, 2021
#97) (#99)

Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.

When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable.

In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable.

Drop the gather_images from the default gathering. It can be still called explicitly.

Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces.

Remove many duplications.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants