-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targeted gathering to collect VM information #96
Conversation
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c1db0e9
to
ea267fd
Compare
/test kubevirt-must-gather-e2e-azure |
@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ea267fd
to
9f66892
Compare
/hold First, we'll build some stabilization branches |
@nunnatsa what do you think of collecting node-gather data for the node on which the VM is running (or failed to run) ? |
We need to do that carefully. We removed this some time ago from the default kubevirt-gathering, sine kubelet logs are huge, and collecting node info is supported in the openshift's must-gather. |
I'm referring to gather_nodes, but in this context only for the node related to the vm, not for all of the nodes. If it doesn't bring any value to debugging single vm failure, then ignore it. |
Maybe we can read a specific node as a targeted gathering, but not as part of this PR. |
/unhold |
8519cdb
to
d6cb3eb
Compare
Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
d6cb3eb
to
a2dd402
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa, tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approved |
/test kubevirt-must-gather-e2e-azure |
@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test kubevirt-must-gather-e2e-azure |
@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…irt#96 and kubevirt#97) Add targeted gathering to collect VM information (kubevirt#96) Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name. When running tasks in parallel, it is now possible to overide the default number of processes of 5, by setting the `PROS` environment variable. In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable. Drop the gather_images from the default gathering. It can be still called explicitly. Split the namespaces out of the main script to avoif using `--all-namespaces` to inscpect namespaces. Remove many duplications. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
…irt#96 and kubevirt#97) Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name. When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable. In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable. Drop the gather_images from the default gathering. It can be still called explicitly. Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces. Remove many duplications. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
…irt#96 and kubevirt#97) Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name. When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable. In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable. Drop the gather_images from the default gathering. It can be still called explicitly. Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces. Remove many duplications. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
#97) (#100) Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name. When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable. In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable. Drop the gather_images from the default gathering. It can be still called explicitly. Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces. Remove many duplications. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
#97) (#99) Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name. When running tasks in parallel, it is now possible to override the default number of processes of 5, by setting the `PROS` environment variable. In addition, added some support for running locally for development, by overriding the default value `BASE_COLLECTION_PATH` environment variable. Drop the gather_images from the default gathering. It can be still called explicitly. Split the namespaces out of the main script to avoid using `--all-namespaces` to inspect namespaces. Remove many duplications. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Don't collect the VM information by default. Instead, add option to collect only VM information for all the VM in the cluster, all the VMs in a specific namespace or for a specific VM by its name.
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com
Release note: