Skip to content

Commit

Permalink
Merge pull request #927 from kubevirt-bot/cherry-pick-925-to-release-…
Browse files Browse the repository at this point in the history
…v0.18

[release-v0.18] Replace test 'Eventually-Consistently' with 'Eventually-MustPassRepeatedly
  • Loading branch information
kubevirt-bot committed Mar 15, 2024
2 parents 11624d2 + ee1ee76 commit 557a0c0
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions tests/monitoring_test.go
Expand Up @@ -326,18 +326,7 @@ func alertShouldNotBeActive(alertName string) {
return nil
}
return fmt.Errorf("alert %s found", alertName)
}, env.Timeout(), time.Second).ShouldNot(HaveOccurred())

ConsistentlyWithOffset(1, func() error {
alert, err := checkAlert(alertName)
if err != nil {
return err
}
if alert == nil || alert.State == "inactive" {
return nil
}
return fmt.Errorf("alert %s found", alertName)
}, env.ShortTimeout(), time.Second).ShouldNot(HaveOccurred())
}, env.Timeout(), 10*time.Second).MustPassRepeatedly(10).ShouldNot(HaveOccurred())
}

func waitForSeriesToBeDetected(seriesName string) {
Expand Down

0 comments on commit 557a0c0

Please sign in to comment.