Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-instancetypes unable to cleanup if CRDs removed first #466

Closed
lyarwood opened this issue Dec 13, 2022 · 0 comments · Fixed by #467
Closed

common-instancetypes unable to cleanup if CRDs removed first #466

lyarwood opened this issue Dec 13, 2022 · 0 comments · Fixed by #467

Comments

@lyarwood
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

$ ./hack/kubevirt.sh kubectl get ssps -n kubevirt
selecting docker as container runtime
NAME         PHASE
ssp-sample   Deployed
$ ./hack/kubevirt.sh kubectl delete crds/virtualmachineclusterinstancetypes.instancetype.kubevirt.io
selecting docker as container runtime
customresourcedefinition.apiextensions.k8s.io "virtualmachineclusterinstancetypes.instancetype.kubevirt.io" deleted
$ ./hack/kubevirt.sh kubectl delete ssps/ssp-sample -n kubevirt 
selecting docker as container runtime
ssp.ssp.kubevirt.io "ssp-sample" deleted
[ .. ] # hangs
{"level":"error","ts":1670953609.2132642,"msg":"Reconciler error","controller":"ssp","controllerGroup":"ssp.kubevirt.io","controllerKind":"SSP","sSP":{"name":"ssp-kubevirt-hyperconverged","namespace":"openshift-cnv"},"namespace":"openshift-cnv","name":"ssp-kubevirt-hyperconverged","reconcileID":"ef59f733-5285-40e0-8822-bd24ec4d63fc","error":"no matches for kind \"VirtualMachineClusterInstancetype\" in version \"instancetype.kubevirt.io/v1alpha2\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234"}
{"level":"info","ts":1670953609.2255187,"logger":"controllers.SSP","msg":"Starting reconciliation","ssp":"openshift-cnv/ssp-kubevirt-hyperconverged"}
{"level":"error","ts":1670953614.2102036,"msg":"Reconciler error","controller":"ssp","controllerGroup":"ssp.kubevirt.io","controllerKind":"SSP","sSP":{"name":"ssp-kubevirt-hyperconverged","namespace":"openshift-cnv"},"namespace":"openshift-cnv","name":"ssp-kubevirt-hyperconverged","reconcileID":"85baa894-0825-4b4f-8132-15391bae90ce","error":"no matches for kind \"VirtualMachineClusterInstancetype\" in version \"instancetype.kubevirt.io/v1alpha2\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234"}

What you expected to happen:
Cleanup should be resilient to the CRDs not being present.

How to reproduce it:
As above.

Anything else we need to know?:
Discovered when using HCO to delete both KubeVirt and SSP at the same time.

Environment:

  • KubeVirt version (use virtctl version):
  • Kubernetes version (use kubectl version):
  • SSP Operator version:
  • VM or VMI specifications:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant