common-instancetypes: Ensure CRDs are present before Cleanup #467
Conversation
This change ensure the VirtualMachineCluster{Instancetype,Preference}
CRDs are present before attempting to cleanup resources from the
cluster. This is required as operators such as HCO remove dependent
projects such as KubeVirt and the SSP operator in parallel thus cleanup
must be resilient to the CRDs already being removed.
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
kubevirt-bot
added
release-note-none
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Looks good to me, but I wonder if common.Cleanup should also be changed? It ignores not found errors, but it could also ignore unknown errors? (When a CRD is deleted all CRs are deleted as well)
See:
ssp-operator/internal/common/resource.go
Line 229 in b9ad74a
Giving you a chance to comment on this.
/approve
/lgtm
/hold
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
/hold cancel Thanks @0xFelix, lets land the fix as is for now and follow up with @akrejcir in the new year about taking that approach as it will impact a few operands. |
kubevirt-bot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
A quick follow up to kubevirt#467 to provide functional test coverage of the behaviour through some existing but previously missed cleanup tests. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
/retest-required |
A quick follow up to kubevirt#467 to provide functional test coverage of the behaviour through some existing but previously missed cleanup tests. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
/retest-required |
A quick follow up to kubevirt#467 to provide functional test coverage of the behaviour through some existing but previously missed cleanup tests. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
What this PR does / why we need it:
This change ensure the VirtualMachineCluster{Instancetype,Preference} CRDs are present before attempting to cleanup resources from the cluster. This is required as operators such as HCO remove dependent projects such as KubeVirt and the SSP operator in parallel thus cleanup must be resilient to the CRDs already being removed.
Which issue(s) this PR fixes:
Fixes #466
Special notes for your reviewer:
Release note: