Delete immutable resources only if immutable part was changed #289
Conversation
kubevirt-bot
added
release-note-none
|
/retest |
|
I need to change one more thing. |
kubevirt-bot
added
the
do-not-merge/hold
Usually only the .spec field of resource is immutable, .metadata and .status can be updated. With this change, the resource is only deleted if .spec is changed, otherwise it is updated. Partially fixes bug: https://bugzilla.redhat.com/show_bug.cgi?id=2037290 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
When the spec of an immutable resource is changed, the operator will delete and recreate it. In the duration since the resource was deleted, but before it is created, the SSP phase should not be Deployed. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
fix-dataimportcron-loop
branch
from
dd7f0f4
to
e4e65d7
Compare
|
/hold cancel |
|
Kudos, SonarCloud Quality Gate passed!
|
kubevirt-bot
removed
the
do-not-merge/hold
|
/retest |
|
@akrejcir: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Overriding the test of upgrade from old operator. The old operator does not work on new cluster version that is used in CI. /override ci/prow/e2e-upgrade-from-old-operator-functests |
|
@akrejcir: Overrode contexts on behalf of akrejcir: ci/prow/e2e-upgrade-from-old-operator-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Usually only the
.specfield of resource is immutable,.metadataand.statuscan be updated.With this PR, the resource is only deleted, if
.specis changed, otherwise it is updated.Which issue(s) this PR fixes:
Partially fixes bug: https://bugzilla.redhat.com/show_bug.cgi?id=2037290
Release note: