-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new column #328
Add new column #328
Conversation
When 'oc get ssp' command is executed, that te '.status.phase' field will be displayed. Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
Hi @opokornyy. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The failing test is flaky and unrelated to this change. /retest |
/retest |
2 similar comments
/retest |
/retest |
@opokornyy One small thing: Can you run |
Looks good to me, but a release note would be helpful in my opinion. |
Results of running 'go run vendor' and 'go mod tidy'. Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
Kudos, SonarCloud Quality Gate passed!
|
/lgtm |
I agree with @0xFelix , some brief releasenote text would be nice here if you have time @opokornyy, otherwise this looks ready. |
Thanks :) /approve |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir, ksimon1, lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir, ksimon1, lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When 'oc get ssp' command is executed,
that the '.status.phase' field will be displayed.
Which issue(s) this PR fixes:
Fixes # #322
Release note:
Signed-off-by: Ondrej Pokorny opokorny@redhat.com