Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new column #328

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Add new column #328

merged 2 commits into from
Mar 29, 2022

Conversation

opokornyy
Copy link
Contributor

@opokornyy opokornyy commented Mar 24, 2022

What this PR does / why we need it:

When 'oc get ssp' command is executed,
that the '.status.phase' field will be displayed.

Which issue(s) this PR fixes:
Fixes # #322

Release note:

Print column Phase when getting SSP objects by 'oc get ssp' command.

Signed-off-by: Ondrej Pokorny opokorny@redhat.com

When 'oc get ssp' command is executed,
that te '.status.phase' field will be displayed.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

Hi @opokornyy. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 24, 2022
@ksimon1
Copy link
Member

ksimon1 commented Mar 24, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2022
@akrejcir
Copy link
Collaborator

The failing test is flaky and unrelated to this change.

/retest

@akrejcir
Copy link
Collaborator

/retest

2 similar comments
@akrejcir
Copy link
Collaborator

/retest

@akrejcir
Copy link
Collaborator

/retest

@akrejcir
Copy link
Collaborator

@opokornyy One small thing: Can you run go mod vendor and go mod tidy ? It will update the copy of api package that is in the vendor directory.

@0xFelix
Copy link
Member

0xFelix commented Mar 28, 2022

Looks good to me, but a release note would be helpful in my opinion.

Results of running 'go run vendor' and 'go mod tidy'.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@lyarwood
Copy link
Member

I agree with @0xFelix , some brief releasenote text would be nice here if you have time @opokornyy, otherwise this looks ready.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 29, 2022
@lyarwood
Copy link
Member

Thanks :)

/approve

@akrejcir
Copy link
Collaborator

/approve

1 similar comment
@ksimon1
Copy link
Member

ksimon1 commented Mar 29, 2022

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir, ksimon1, lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir, ksimon1, lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@kubevirt-bot kubevirt-bot merged commit 6c9da39 into kubevirt:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants