Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix setting namespace for example pipelines role binding #554

Merged
merged 1 commit into from May 23, 2023
Merged

fix: fix setting namespace for example pipelines role binding #554

merged 1 commit into from May 23, 2023

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented May 23, 2023

What this PR does / why we need it:
fix: fix setting namespace for example pipelines role binding

one role binding for example pipeline has to be deployed to the kubevirt-os-images namespace. SSP operator will not set namespace for roleBindings if they have namespace defined.

Release note:

NONE

@ksimon1
fix: fix setting namespace for example pipelines role binding
d578a8b 
one role binding for example pipeline has to be deployed
to the kubevirt-os-images namespace. SSP operator will not
set namespace for roleBindings if they have namespace defined.

Signed-off-by: Karel Šimon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

Lgtm for now, because we need this soon. But IMHO it's not a good design. We should use some other method to decide if the namespace should be set or not. Maybe an annotation, label, or a test on its name.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@0xFelix
Copy link
Member

0xFelix commented May 23, 2023

/approve

I would very much appreciate if we could investigate if it is possible to remove the additional roles / SAs in the pipelines again.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@kubevirt-bot kubevirt-bot merged commit 66f037f into kubevirt:master May 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ksimon1 @akrejcir @0xFelix @kubevirt-bot