feat: Add checking that all files are committed #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
opokornyy
changed the title
opokornyy
force-pushed
the
make-vendor-check
branch
from
3ac2424
to
d8710a9
Compare
opokornyy
force-pushed
the
make-vendor-check
branch
6 times, most recently
from
1674124
to
83f94f9
Compare
0xFelix
reviewed
Jun 7, 2023
opokornyy
force-pushed
the
make-vendor-check
branch
3 times, most recently
from
40daef3
to
bd6e236
Compare
opokornyy
changed the title
0xFelix
reviewed
Jun 12, 2023
|
|
||
| check_make vendor | ||
| check_make generate | ||
| check_make manifests |
This commit modifies the Makefile to execute script that checks whether all generated files are committed. Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
opokornyy
force-pushed
the
make-vendor-check
branch
from
bd6e236
to
e019de1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the Makefile to execute script that checks whether all files are committed.
Release note: