Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CNV-30284): rename tekton images env vars #592

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix(CNV-30284): rename tekton images env vars #592

merged 1 commit into from
Jun 27, 2023

Conversation

codingben
Copy link
Member

What this PR does / why we need it:

Rename Tekton environment variables to be the
same as declared in CSV. Currently, they are not
the same as in CSV and no value is set.

Release note:

Fix Tekton images enviroment variables.

@codingben
fix(CNV-30284): rename tekton images env vars
80bd3b3 
Rename Tekton environment variables to be the
same as declared in CSV. Currently, they are not
the same as in CSV and no value is set.

Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ksimon1
Copy link
Member

ksimon1 commented Jun 26, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
0xFelix
0xFelix approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@kubevirt-bot kubevirt-bot merged commit c56ed4f into kubevirt:master Jun 27, 2023
11 checks passed
@codingben
Copy link
Member Author

/cherry-pick release-v0.18

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 27, 2023
Merged
@kubevirt-bot
Copy link
Contributor

@codingben: new pull request created: #599

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akrejcir pushed a commit that referenced this pull request Jun 28, 2023
@kubevirt-bot @akrejcir
Merge pull request #592 from codingben/CNV-30284
dbb130f 
fix(CNV-30284): rename tekton images env vars
@codingben codingben deleted the CNV-30284 branch June 28, 2023 14:21
@codingben codingben restored the CNV-30284 branch June 28, 2023 14:21
@codingben codingben deleted the CNV-30284 branch June 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codingben @ksimon1 @kubevirt-bot @0xFelix