Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-instancetypes: Move to instancetype.kubevirt.io/v1beta1 #593

Merged
merged 4 commits into from
Jun 27, 2023
Merged

common-instancetypes: Move to instancetype.kubevirt.io/v1beta1 #593

merged 4 commits into from
Jun 27, 2023

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jun 26, 2023 •
edited

What this PR does / why we need it:

kubevirt.io/api v1.0.0-rc.0 is also pulled in but the underlying dependency on k8s.io/api is pinned to v0.26.2 for now as moving to v0.27.3 requires a large amount of work in SSP operator thanks to changes to controller-runtime v0.15.0, see #598 for more on that work.

Which issue(s) this PR fixes:

Fixes #590

Special notes for your reviewer:

Release note:

 The `instancetype.kubevirt.io/v1beta1` API is now used by the `common-instancetypes` operand

@lyarwood
chore: Update to kubevirt.io/api to v1.0.0-rc.0
a3c20be 
k8s.io/api is pinned to v0.26.2 to avoid dependency hell when moving to
v0.27.3. A follow up PR will handle that much larger move.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 26, 2023
@lyarwood
Copy link
Member Author

/cherry-pick v0.18

@kubevirt-bot
Copy link
Contributor

@lyarwood: once the present PR merges, I will cherry-pick it on top of v0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood
Copy link
Member Author

/cc @akrejcir

Kudos to @0xFelix for suggesting the hackaround to avoid the k8s.io/api@v0.27.3 bump.

@lyarwood lyarwood force-pushed the switch-to-instancetype-v1beta1 branch from c0800e1 to b1485c7 Compare June 26, 2023 14:10
@lyarwood
chore: Update Ginkgo to 2.9.1
325676f 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the switch-to-instancetype-v1beta1 branch from b1485c7 to 2862b25 Compare June 26, 2023 15:48
@lyarwood
common-instancetypes: Move to instancetype.kubevirt.io/v1beta1
014ef7a 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the switch-to-instancetype-v1beta1 branch from 2862b25 to 014ef7a Compare June 26, 2023 17:15
@lyarwood
automation: Pin KubeVirt to v1.0.0-rc.0 to enable testing ahead of GA
abd5b2e 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lyarwood lyarwood mentioned this pull request Jun 26, 2023
Merged
0xFelix
0xFelix reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but one question about upgrading. What happens if SSP is upgraded and v1alpha2 instancetypes and preferences need to be updated to v1beta1?

@lyarwood
Copy link
Member Author

Looks good so far, but one question about upgrading. What happens if SSP is upgraded and v1alpha2 instancetypes and preferences need to be updated to v1beta1?

The underlying storage migration is taken care of by cluster-kube-storage-version-migrator-operator in OCP/OKD environments and even before then they will be served as v1beta1 objects anyway by KubeVirt v1.0.0-rc.0 and above.

I blogged about this below but I can follow up with more documentation in this repo if you'd like as it's not directly related to this change but the introduction of common-instancetypes >= v0.2.0 and kubevirt >= v1.0.0-rc.0:

https://blog.yarwood.me.uk/2023/06/22/kubevirt_instancetype_update_5/#instancetypekubevirtiov1alpha12-deprecation

akrejcir
akrejcir reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@akrejcir akrejcir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
0xFelix
0xFelix approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@kubevirt-bot kubevirt-bot merged commit 2bcf3fe into kubevirt:master Jun 27, 2023
11 checks passed
@kubevirt-bot
Copy link
Contributor

@lyarwood: cannot checkout v0.18: error checking out v0.18: exit status 1. output: error: pathspec 'v0.18' did not match any file(s) known to git

In response to this:

/cherry-pick v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood
Copy link
Member Author

/cherry-pick release-v0.18

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 27, 2023
Merged
@kubevirt-bot
Copy link
Contributor

@lyarwood: new pull request created: #602

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akrejcir pushed a commit that referenced this pull request Jun 28, 2023
@kubevirt-bot @akrejcir
Merge pull request #593 from lyarwood/switch-to-instancetype-v1beta1
0a912a0 
common-instancetypes: Move to `instancetype.kubevirt.io/v1beta1`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir akrejcir left review comments

@0xFelix 0xFelix 0xFelix approved these changes

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move common-instancetypes operand to instancetype.kubevirt.io/v1beta1
4 participants
@lyarwood @kubevirt-bot @0xFelix @akrejcir