Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename tekton operands #615

Merged
merged 1 commit into from
Jul 4, 2023
Merged

chore: rename tekton operands #615

merged 1 commit into from
Jul 4, 2023

Conversation

codingben
Copy link
Member

What this PR does / why we need it:

Rename Tekton operands from tekton-*.go to
reconcile.go to be similar as in other operands.

Special notes for your reviewer:

Not necessarily needed to be backported. As you wish.

Release note:

None

@codingben
chore: rename tekton operands
cc57a57 
Rename Tekton operands from tekton-*.go to
reconcile.go to be similar as in other operands.

Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codingben
Copy link
Member Author

codingben commented Jul 2, 2023 •
edited

/cc @ksimon1 @0xFelix

@kubevirt-bot
Copy link
Contributor

@codingben: GitHub didn't allow me to request PR reviews from the following users: ksimon.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ksimon @0xFelix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot requested a review from 0xFelix July 2, 2023 08:42
@codingben
Copy link
Member Author

/cc @ksimon1

@kubevirt-bot kubevirt-bot requested a review from ksimon1 July 2, 2023 08:43
0xFelix
0xFelix reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I'm fine with it, but please no backport.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@ksimon1
Copy link
Member

ksimon1 commented Jul 4, 2023

/lgtm
please bare in your mind, that midstream dockerfile will have to be updated after this change.
And I agree with Felix, this PR should not be backported.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@kubevirt-bot kubevirt-bot merged commit 56183a5 into kubevirt:main Jul 4, 2023
13 of 14 checks passed
@codingben
Copy link
Member Author

@ksimon1 Yes, that dockerfile was updated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@akrejcir akrejcir Awaiting requested review from akrejcir

@lyarwood lyarwood Awaiting requested review from lyarwood

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codingben @kubevirt-bot @ksimon1 @0xFelix