Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GH actions for bumping virtio version #628

Merged
merged 1 commit into from Jul 19, 2023
Merged

fix: GH actions for bumping virtio version #628

merged 1 commit into from Jul 19, 2023

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jul 19, 2023

What this PR does / why we need it:
fix: GH actions for bumping virtio version
script contained wrong paths for files, which need update

Release note:

NONE

@ksimon1
fix: GH actions for bumping virtio version
5ae7cb1 
script contained wrong paths for files, which need update

Signed-off-by: Karel Simon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

0xFelix
0xFelix approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@akrejcir
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@kubevirt-bot kubevirt-bot merged commit 20cbafd into kubevirt:main Jul 19, 2023
7 checks passed
@akrejcir
Copy link
Collaborator

@ksimon1 Should this be backported?

@ksimon1
Copy link
Member Author

ksimon1 commented Aug 16, 2023

I don't think we should backport this PR, on the other hand this PR can be backported #635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@lyarwood lyarwood Awaiting requested review from lyarwood

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ksimon1 @akrejcir @kubevirt-bot @0xFelix