Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.18] chore: Audit template validator RBAC rules. #659

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[release-v0.18] chore: Audit template validator RBAC rules. #659

merged 1 commit into from
Aug 17, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #622

/assign akrejcir

Audit template validator RBAC rules

@jcanocan
chore: Audit template validator RBAC rules.
5cc6022 
Template validator has and reconciles their owns RBAC rules. It generates
the `template:view` ClusterRole for multiple task such as functional
testing. In order to be deployed and run functional test the `get` verb
is not required on resources `templates` and `virtualmachines`.

Signed-off-by: Javier Cano Cano <jcanocan@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 16, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@akrejcir
Copy link
Collaborator

/retest

0xFelix
0xFelix approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@kubevirt-bot kubevirt-bot merged commit 3458f0d into kubevirt:release-v0.18 Aug 17, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyarwood lyarwood Awaiting requested review from lyarwood

@0xFelix 0xFelix Awaiting requested review from 0xFelix

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubevirt-bot @akrejcir @0xFelix @jcanocan