Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-instancetypes: Add DeployCommonInstancetypes featureGate #702

Merged
merged 2 commits into from Oct 30, 2023
Merged

common-instancetypes: Add DeployCommonInstancetypes featureGate #702

merged 2 commits into from Oct 30, 2023

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

Based on #661

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

TBD

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 11, 2023
@github-actions
Copy link

/cc sradco

0xFelix
0xFelix reviewed Oct 12, 2023
View reviewed changes
api/v1beta2/ssp_types.go Show resolved Hide resolved
internal/operands/common-instancetypes/reconcile_test.go
_, err = operand.Reconcile(&request)
Expect(err).ToNot(HaveOccurred())

virtualMachineClusterInstancetypes, err := FetchBundleResource[instancetypev1beta1.VirtualMachineClusterInstancetype](instancetypePath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you access operand.virtualMachineClusterInstancetypes and operand.virtualMachineClusterPreferences here instead of creating a separate list of resources?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we'd just be asserting that the resources the operand knows about have been reconciled. Appreciate it's the same code but I wanted to be ensure that the expected resources are reconciled here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2023
@lyarwood @0xFelix
common-instancetypes: Remove args from reconcileRemovedResources
2f3368b 
Co-authored-by: Felix Matouschek <fmatouschek@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@0xFelix 0xFelix force-pushed the common-instancetypes-featuregate branch from fbc62f6 to 0ee1e2a Compare October 26, 2023 10:06
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2023
@0xFelix 0xFelix marked this pull request as ready for review October 26, 2023 10:07
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
jcanocan
jcanocan reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jcanocan jcanocan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job once again! Thanks for taking Lee's PR in his absence :)

internal/operands/common-instancetypes/reconcile.go Show resolved Hide resolved
tests/common_instancetypes_test.go Show resolved Hide resolved
@akrejcir
Copy link
Collaborator

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@0xFelix 0xFelix force-pushed the common-instancetypes-featuregate branch from 0ee1e2a to fa11da3 Compare October 27, 2023 15:00
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@0xFelix
Copy link
Member

0xFelix commented Oct 30, 2023

/retest-required

@lyarwood @0xFelix
common-instancetypes: Add DeployCommonInstancetypes featureGate
7648d29 
This change adds a simple DeployCommonInstancetypes feature gate to the
SSP CR. This feature gate defaults to true to keep the original
behaviour of the common-instancetypes operand.

When disabled, any previously deployed resources are removed.

Co-authored-by: Felix Matouschek <fmatouschek@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@0xFelix 0xFelix force-pushed the common-instancetypes-featuregate branch from fa11da3 to 7648d29 Compare October 30, 2023 09:32
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@kubevirt-bot kubevirt-bot merged commit 8913687 into kubevirt:main Oct 30, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@akrejcir akrejcir akrejcir left review comments

@ksimon1 ksimon1 ksimon1 left review comments

@jcanocan jcanocan jcanocan left review comments

@opokornyy opokornyy Awaiting requested review from opokornyy

@sradco sradco Awaiting requested review from sradco

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lyarwood @akrejcir @kubevirt-bot @0xFelix @ksimon1 @jcanocan