Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VirtualMachineCRCErrors not stop firing #742

Merged
merged 2 commits into from Jan 9, 2024
Merged

Fix VirtualMachineCRCErrors not stop firing #742

merged 2 commits into from Jan 9, 2024

Commits on Jan 8, 2024

  1. Fix VirtualMachineCRCErrors not getting resolved 

    The controller keeps reporting old metric values
even after the VM is deleted. This commit updates
the metric name and labels so that we can set up
the metric value to 0, and no longer trigger the
alert on VM deletion

Signed-off-by: João Vilaça <jvilaca@redhat.com>
    @machadovilaca
    machadovilaca committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1095ef5 View commit details
    Browse the repository at this point in the history

  2. Add offset to ginkgo e2e validations 

    Signed-off-by: João Vilaça <jvilaca@redhat.com>
    @machadovilaca
    machadovilaca committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7af6434 View commit details
    Browse the repository at this point in the history