Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update golangci-lint to v1.55.2 #789

Merged
merged 1 commit into from Dec 22, 2023

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Dec 21, 2023

What this PR does / why we need it:

Update golangci-lint to v1.55.2 and fix all issues the new versions uncovers.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

None

Update golangci-lint to v1.55.2 and fix all issues the new versions
uncovers.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 21, 2023
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@0xFelix
Copy link
Member Author

0xFelix commented Dec 21, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@0xFelix
Copy link
Member Author

0xFelix commented Dec 21, 2023

/retest-required

Copy link

openshift-ci bot commented Dec 21, 2023

@0xFelix: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-functests 9d4351f link true /test e2e-upgrade-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@0xFelix
Copy link
Member Author

0xFelix commented Dec 22, 2023

/retesst

@0xFelix
Copy link
Member Author

0xFelix commented Dec 22, 2023

/override ci/prow/e2e-upgrade-functests

@kubevirt-bot
Copy link
Contributor

@0xFelix: Overrode contexts on behalf of 0xFelix: ci/prow/e2e-upgrade-functests

In response to this:

/override ci/prow/e2e-upgrade-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit d3562eb into kubevirt:main Dec 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants