Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase partition1 size in windows efi configmaps #840

Merged
merged 1 commit into from Jan 17, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jan 17, 2024

What this PR does / why we need it:
fix: increase partition1 size in windows efi configmaps
The windows11-autounattend configMap set the partition1 to 300MB, which is the minimum according to documentation. In practice, however, this causes the installer to create an extra partition at the end of the C: partition, blocking it from expanding. Then during windows update the disk fills up. This commit updates it to 700MB.

Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/CNV-36289

Special notes for your reviewer:

Release note:

fix: increase partition1 size in windows efi configmaps

The windows11-autounattend configMap set the partition1 to 300MB,
which is the minimum according to documentation. In practice,
however, this causes the installer to create an extra partition at
the end of the C: partition, blocking it from expanding. Then during
windows update the disk fills up. This commit updates it to 700MB.

Signed-off-by: Karel Simon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 17, 2024
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@jcanocan
Copy link
Contributor

/lgtm

@ksimon1
Copy link
Member Author

ksimon1 commented Jan 17, 2024

/retest
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@kubevirt-bot kubevirt-bot merged commit 1d6f1e9 into kubevirt:main Jan 17, 2024
15 checks passed
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 18, 2024

/cherry-pick release-v0.19

@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #844

In response to this:

/cherry-pick release-v0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants