feat: update golang to 1.21 #854
Conversation
kubevirt-bot
added
release-note
.github/workflows/pull-request.yaml
Outdated
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.20' | ||
| go-version: '1.21' |
There was a problem hiding this comment.
You could make it use the golang version set in go.mod, so we don't have to touch this file in the future.
There was a problem hiding this comment.
kubevirt-bot
added
lgtm
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.20' | ||
| go-version-file: 'go.mod' |
There was a problem hiding this comment.
This action setup-go needs to be executed after the below actions/checkout, because at this stage the code has not yet been checked out, so go.mod file does not exist.
Signed-off-by: Karel Simon <ksimon@redhat.com>
|
|
/lgtm |
|
@ksimon1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override e2e-single-node-functests |
|
@ksimon1: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-functests |
|
@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/e2e-functests, ci/prow/e2e-single-node-functests, ci/prow/e2e-upgrade-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
feat: update golang to 1.21
Release note: