Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.19] Update VM controller error handling #857

Merged
merged 1 commit into from Jan 25, 2024
Merged

[release-v0.19] Update VM controller error handling #857

merged 1 commit into from Jan 25, 2024

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #850

/assign machadovilaca

Update VM controller error handling

@machadovilaca
Update VM controller error handling
6fd78d6 
- adds 5 seconds backoff between failed reconcile loops of VM controller
- removes 'error' wording from logs when VM controller does not create the VM related metrics
- skips metric creation when VM related resources are still in Provisioning status

Signed-off-by: João Vilaça <jvilaca@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jan 24, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@akrejcir
Copy link
Collaborator

akrejcir commented Jan 24, 2024 •
edited

release-v0.19 branch is for version 4.15, but the Jira ticket is targeted to 4.16.

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@ksimon1
Copy link
Member

ksimon1 commented Jan 24, 2024

/retest

@machadovilaca
Copy link
Member

machadovilaca commented Jan 25, 2024 •
edited

release-v0.19 branch is for version 4.15, but the Jira ticket is targeted to 4.16.

/hold

@akrejcir I mention if we should backport with the monitoring team, and since this is a low risk PR, with customer-facing improvements, we think it would be good to backport it

edit: jira ticket for 4.15: https://issues.redhat.com/browse/CNV-37611

@akrejcir
Copy link
Collaborator

Ok, thanks for the update. I was making sure that this was planned for 4.15.

/unhold
/approve

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@kubevirt-bot kubevirt-bot merged commit 490e0e5 into kubevirt:release-v0.19 Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubevirt-bot @machadovilaca @akrejcir @ksimon1