Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not force IPv4 on metrics service #957

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Apr 12, 2024

What this PR does / why we need it:
The service that exposes metrics used to force IPv4 protocol. It failed in clusters that have only IPv6.

Fixes: https://issues.redhat.com/browse/CNV-40159

Release note:

None

The service that exposes metrics used to force IPv4 protocol.
It failed in clusters that have only IPv6.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 12, 2024
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@akrejcir
Copy link
Collaborator Author

Holding until I verify it.
/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@akrejcir
Copy link
Collaborator Author

The CI fails because of: https://issues.redhat.com/browse/CNV-40547

@akrejcir
Copy link
Collaborator Author

/retest

@akrejcir
Copy link
Collaborator Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@akrejcir
Copy link
Collaborator Author

/cc @ksimon1 @0xFelix

@dominikholler
Copy link
Contributor

Please do not block merging on the verification.

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks good to me.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@lyarwood
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@kubevirt-bot kubevirt-bot merged commit ce95154 into kubevirt:main Apr 19, 2024
12 checks passed
@akrejcir akrejcir deleted the fix-ipv6 branch April 19, 2024 09:00
@akrejcir
Copy link
Collaborator Author

/cherry-pick release-v0.20

@kubevirt-bot
Copy link
Contributor

@akrejcir: new pull request created: #965

In response to this:

/cherry-pick release-v0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

/cherry-pick release-v0.19

@kubevirt-bot
Copy link
Contributor

@akrejcir: new pull request created: #969

In response to this:

/cherry-pick release-v0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants