Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.18] fix: Remove namespaceSelector from webhook definition #979

Merged

Commits on May 2, 2024

  1. fix: Remove namespaceSelector from webhook definition

    The ValidatingWebhookConfiguration created by OLM can have
    namespaceSelector field set. We don't want that, because
    the webhook checks that there is only one SSP resource
    in the cluster.
    
    This commit adds a controller that watches
    ValidatingWebhookConfigurations and removes the namespaceSelector,
    if the object has a specific label.
    
    Cherry-pick fron: 948eeaa
    
    Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
    akrejcir committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b588f9c View commit details
    Browse the repository at this point in the history
  2. fix: webhook-controller backport

    Some changes were needed from the PR in main branch.
    - "slices" package is not yet in go 1.19
    - The "TypeMeta" needs to be defined in objects used in unit tests.
    - Do not use "k8s.io/utils/ptr" package.
    
    Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
    akrejcir committed May 2, 2024
    Configuration menu
    Copy the full SHA
    52995a8 View commit details
    Browse the repository at this point in the history