Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to check if tto is not deploying anything when DeployTektonTaskResouces set to false #13

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

opokornyy
Copy link
Contributor

@opokornyy opokornyy commented Apr 11, 2022

What this PR does / why we need it:
Add tests to check if tto is not deploying anything when DeployTektonTaskResouces set to false

Fixes: #4
Release note:


Signed-off-by: Ondrej Pokorny opokorny@redhat.com

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2022
@openshift-ci openshift-ci bot requested review from 0xFelix and ksimon1 April 11, 2022 08:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opokornyy
To complete the pull request process, please assign ksimon1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @ksimon1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 11, 2022
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

Hi @opokornyy. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added size/M needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 11, 2022
…TaskResouces set to false

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2022
@opokornyy opokornyy changed the title [WIP] Add tests to check if tto is not deploying anything when DeployTektonTaskResouces set to false Add tests to check if tto is not deploying anything when DeployTektonTaskResouces set to false Apr 12, 2022
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022
@ksimon1
Copy link
Member

ksimon1 commented Apr 12, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2022
@ksimon1 ksimon1 merged commit d4c4e0d into kubevirt:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test which checks if tto is not deploying resources when is deployed
3 participants