Document volumes and disks #13
Conversation
rmohr
force-pushed
the
volumes-and-disks
branch
from
835828f
to
53344f8
Compare
disks-and-volumes.md
Outdated
|
|
||
| ### lun | ||
|
|
||
| A `lun` disk will expose the volume as a LUN device to the vm. |
There was a problem hiding this comment.
Could you link to a definition of lun - especially in contrast to disks.
There was a problem hiding this comment.
Not sure where to link. The difference is what you see in the guest. Do you mean linking to the api-reference?
There was a problem hiding this comment.
IIUIC then the diffrerence between lun and disk is that with lun more scsi calls are passed through disk is somewhat filtering it - that's at least what I get from the libvirt docs.
Is there any other difference I am missing?
There was a problem hiding this comment.
I can add to the api-reference docs that this allows generic iscsi command passthrough.
There was a problem hiding this comment.
Yep, that would work for me, or even just a sentence here differentiating lun from disk. At least some hint how they differ :)
| - name: mypvcdisk | ||
| volumeName: mypvc | ||
| # This makes it a lun device | ||
| lun: {} |
There was a problem hiding this comment.
I like the empty structs for - empty structs :)
(lun: {} vs lun:)
I'll see that I have an eye on this in examples in general.
There was a problem hiding this comment.
lun: is equivalent to lun: null, whereas lun: {} is an empty struct/dict. So having {} means it is present, whereas lun: is the same as not specifying it.
There was a problem hiding this comment.
Oh, yes, Indeed. i didn't realize this initially, thanks.
disks-and-volumes.md
Outdated
|
|
||
| ### cloudInitNoCloud | ||
|
|
||
| Allows attaching `cloudInitNoCloud` data-sources to the vm. If the vm contains |
| @@ -0,0 +1,315 @@ | |||
| # Volumes and Disks | |||
|
|
|||
There was a problem hiding this comment.
Maybe a few introductional words to state that th eterm disk coins the guest facing side, whereas volumes specifies the kube source side.
rmohr
force-pushed
the
volumes-and-disks
branch
2 times, most recently
from
9bce89b
to
cdc312c
Compare
Signed-off-by: Roman Mohr <rmohr@redhat.com>
rmohr
force-pushed
the
volumes-and-disks
branch
from
cdc312c
to
eee1e5f
Compare
Document which volume and disk types are supported in KubeVirt and how connecting them works.