Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Add map disk interface method #110

Merged
merged 3 commits into from Apr 21, 2020
Merged

Conversation

machacekondra
Copy link
Contributor

This PR changes:

  • remove Must methods
  • Refactor disk mapping
  • add disk interface method (so we can map virtio_scsi for example)

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels Apr 21, 2020
@pkliczewski pkliczewski added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 21, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 21, 2020
Signed-off-by: Ondra Machacek <omachace@redhat.com>
Signed-off-by: Ondra Machacek <omachace@redhat.com>
Signed-off-by: Ondra Machacek <omachace@redhat.com>
@jakub-dzon jakub-dzon merged commit 092cdc3 into kubevirt:master Apr 21, 2020
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jakub-dzon, machacekondra, masayag, pkliczewski
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants