Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Reduce restrictions on targer in mappings #261

Merged
merged 1 commit into from May 29, 2020
Merged

Reduce restrictions on targer in mappings #261

merged 1 commit into from May 29, 2020

Conversation

pkliczewski
Copy link
Contributor

We allow for target not to be there and we would use defaults.

Signed-off-by: Piotr Kliczewski piotr.kliczewski@gmail.com

@pkliczewski
Reduce restrictions on targer in mappings
273c360 
We allow for target not to be there and we would use defaults.

Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>
@pkliczewski pkliczewski added the release-note-none Denotes a PR that doesn't merit a release note. label May 28, 2020
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels May 28, 2020
@pkliczewski
Copy link
Contributor Author

@suomiy FYI

@pkliczewski
Copy link
Contributor Author

/retest

2 similar comments
@pkliczewski
Copy link
Contributor Author

/retest

@pkliczewski
Copy link
Contributor Author

/retest

@pkliczewski
Copy link
Contributor Author

/test pull-vm-import-operator-e2e-k8s-1.16

@machacekondra
Copy link
Contributor

/retest

@jakub-dzon
Copy link
Contributor

/test pull-vm-import-operator-e2e-k8s-1.16

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jakub-dzon, machacekondra, pkliczewski
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jakub-dzon jakub-dzon merged commit 811d3e1 into kubevirt:master May 29, 2020
@masayag
Copy link
Contributor

masayag commented Jun 2, 2020

@jakub-dzon could you update design doc about this change ? for each type disk-mapping/storage-mapping/network-mapping what is assumed to be the defaults to be set by the controller.

@jakub-dzon
Copy link
Contributor

Sure, I will.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakub-dzon jakub-dzon jakub-dzon approved these changes

@machacekondra machacekondra machacekondra approved these changes

@masayag masayag Awaiting requested review from masayag

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkliczewski @machacekondra @jakub-dzon @kubevirt-bot @masayag