This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Using pod network type as default when type is missing in the resource mapping #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/work-in-progress
kubevirt-bot
removed
the
do-not-merge/work-in-progress
kubevirt-bot
added
the
do-not-merge/work-in-progress
machacekondra
approved these changes
Jun 24, 2020
jakub-dzon
force-pushed
the
unsupported-target-net-type-e2e
branch
from
64e7229
to
3899e56
Compare
jakub-dzon
changed the title
jakub-dzon
force-pushed
the
unsupported-target-net-type-e2e
branch
from
3899e56
to
355d82c
Compare
jakub-dzon
force-pushed
the
unsupported-target-net-type-e2e
branch
from
355d82c
to
b5466c3
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
…evirt#301 Signed-off-by: Jakub Dzon <jdzon@redhat.com>
jakub-dzon
force-pushed
the
unsupported-target-net-type-e2e
branch
from
b5466c3
to
36a92d6
Compare
pkliczewski
approved these changes
Jun 24, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakub-dzon, machacekondra, pkliczewski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
masayag
reviewed
Jun 24, 2020
| @@ -11,4 +11,6 @@ var ( | |||
| PodType = "pod" | |||
| // MultusType defines `pod` resource mapping network type | |||
| MultusType = "multus" | |||
| // UnsupportedType defines non-existing, unsupported `unsupported resource mapping network type | |||
There was a problem hiding this comment.
@jakub-dzon should the second "`unsupported" be removed from the description ? also there is a missing comma.
There was a problem hiding this comment.
The second "unsupported" is the the value used as unsupported type:) I will fix the missing punctuation mark.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301.
Fixes:
Signed-off-by: Jakub Dzon jdzon@redhat.com