Validate template memory requirements #406
Conversation
Bug-Url: https://bugzilla.redhat.com/1871433 Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>
pkliczewski
added
the
release-note-none
kubevirt-bot
added
dco-signoff: yes
| @@ -263,7 +263,7 @@ func (o *OvirtProvider) Validate() ([]v2vv1.VirtualMachineImportCondition, error | |||
| return []v2vv1.VirtualMachineImportCondition{}, errors.New("VM has not been loaded") | |||
| } | |||
| vmiName := o.GetVmiNamespacedName() | |||
| return o.validator.Validate(vm, &vmiName, o.resourceMapping), nil | |||
| return o.validator.Validate(vm, &vmiName, o.resourceMapping, o.templateFinder), nil | |||
There was a problem hiding this comment.
What do you think about not retrieving the template twice and refactoring into something along these lines?:
- retrieve template in the controller before validation - set it on provider;
- in provider pass the template to validation (instead of the template finder) and
- check whether the template was found (if required) - I think we talked about making it part of validation, not processing;
- check the memory requirements.
There was a problem hiding this comment.
I have been thinking about it but we handle the template differently in both places. As well as we would always fetched it but in some cases validation would fail so it wouldn't be needed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakub-dzon, machacekondra, pkliczewski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bug-Url: https://bugzilla.redhat.com/1871433
Signed-off-by: Piotr Kliczewski piotr.kliczewski@gmail.com