Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Use template validation rules #412

Merged
merged 1 commit into from Oct 1, 2020
Merged

Use template validation rules #412

merged 1 commit into from Oct 1, 2020

Conversation

pkliczewski
Copy link
Contributor

In previous implementation we used resource.memory which was not correct. Now let's base our validation logic on the rules.

Bug-Url: https://bugzilla.redhat.com/1871433
Signed-off-by: Piotr Kliczewski piotr.kliczewski@gmail.com

@pkliczewski pkliczewski added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 30, 2020
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Sep 30, 2020
@masayag
Copy link
Contributor

masayag commented Sep 30, 2020

pls fix CI issue: pkg/providers/ovirt/validation/validators/vm-validator.go:20:2: struct field tag json:"min",omitempty not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces

@pkliczewski
Use template validation rules
53ab9dc 
In previous implementation we used resource.memory which was not correct.
Now let's base our validation logic on the rules.

Bug-Url: https://bugzilla.redhat.com/1871433
Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>
@pkliczewski
Copy link
Contributor Author

not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces

Thanks, should be fixed!

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jakub-dzon, machacekondra, masayag, pkliczewski
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machacekondra machacekondra merged commit 850f8e7 into kubevirt:master Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@masayag masayag masayag approved these changes

@jakub-dzon jakub-dzon jakub-dzon approved these changes

@machacekondra machacekondra machacekondra approved these changes

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkliczewski @masayag @kubevirt-bot @jakub-dzon @machacekondra