This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Add optional AccessMode to StorageResourceMappingItem #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
konveyor/virt-controller would like to be able to specify a supported access mode when creating storage/disk mappings. This adds an
AccessMode
field to theStorageResourceMappingItem
, and adds support for mapping theAccessMode
andVolumeMode
in the vSphere provider.AccessMode
andVolumeMode
will default respectively toReadWriteOnce
andFilesystem
in the vSphere provider.The oVirt provider will take the access mode from the mapping if it's set, otherwise it will determine the access mode as it previously did.