Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Add optional AccessMode to StorageResourceMappingItem #438

Merged
merged 2 commits into from Nov 20, 2020

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Nov 16, 2020

konveyor/virt-controller would like to be able to specify a supported access mode when creating storage/disk mappings. This adds an AccessMode field to the StorageResourceMappingItem, and adds support for mapping the AccessMode and VolumeMode in the vSphere provider.

AccessMode and VolumeMode will default respectively to ReadWriteOnce and Filesystem in the vSphere provider.
The oVirt provider will take the access mode from the mapping if it's set, otherwise it will determine the access mode as it previously did.

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@kubevirt-bot
Copy link

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels Nov 16, 2020
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@mansam mansam changed the title [WIP] Add optional AccessMode to StorageResourceMappingItem Add optional AccessMode to StorageResourceMappingItem Nov 19, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2020
@pkliczewski pkliczewski merged commit e5e0f94 into kubevirt:master Nov 20, 2020
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mansam, pkliczewski
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants