Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Improve DataVolume importer CrashLoopBackoff message #461

Merged
merged 1 commit into from Jan 21, 2021
Merged

Improve DataVolume importer CrashLoopBackoff message #461

merged 1 commit into from Jan 21, 2021

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Jan 18, 2021

If the VM import fails due to the DV importer pod crashlooping, the status on the VMI CR should include the termination message from the failing container.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1910019

@kubevirt-bot
Copy link

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S labels Jan 18, 2021
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 18, 2021
@mansam
Copy link
Contributor Author

mansam commented Jan 19, 2021

/retest

@pkliczewski
Copy link
Contributor

@mansam There is schema validation failure. Please take a look

Discrepancy between CRD and Struct Missing or incorrect schema validation at [/spec/finalizeDate], expected type [object] in CRD file [vmimport-crd]

@pkliczewski
Copy link
Contributor

@mansam Please rebase

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fdupont-redhat, machacekondra, mansam, pkliczewski
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mansam
Improve DataVolume importer CrashLoopBackoff message
a7aa463 
If the VM import fails due to the DV importer pod crashlooping,
the status on the vmi CR should now include the termination
message from the failing container.

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@pkliczewski pkliczewski merged commit 095f8b7 into kubevirt:master Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkliczewski pkliczewski pkliczewski approved these changes

@machacekondra machacekondra machacekondra approved these changes

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mansam @kubevirt-bot @pkliczewski @machacekondra