This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
v2v: Wait for ServiceAccount before creating conversion pod #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1873
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2217
💛 - Coveralls |
atiratree
reviewed
Aug 1, 2019
src/k8s/requests/v2v/constants.js
Outdated
| @@ -14,3 +14,5 @@ export const VMWARE_KUBEVIRT_VMWARE_CONFIG_MAP_NAME = 'v2v-vmware'; | |||
| export const VMWARE_TO_KUBEVIRT_OS_CONFIG_MAP_NAMESPACE = 'kube-public'; // note: common-templates are in the "openshift" namespace | |||
| // TODO: make it configurable via VMWARE_KUBEVIRT_VMWARE_CONFIG_MAP | |||
| export const VMWARE_TO_KUBEVIRT_OS_CONFIG_MAP_NAME = 'vmware-to-kubevirt-os'; // single configMap per cluster, contains mapping of vmware guestId to common-templates OS ID | |||
|
|
|||
| export const CONVERSION_SERVICEACCOUNT_DELAY = 5 * 1000; // in ms | |||
There was a problem hiding this comment.
IMHO, I would rather do more polls more frequently (the operation is not so expensive). The UI would otherwise stall for 5,10 sec before it gets the secrets.
There was a problem hiding this comment.
Changed to up to 15 attempts with 2 secs delay in between.
mareklibra
force-pushed
the
fix-1721018.v2v.RaceConversionPod
branch
from
57e6eee
to
4455ad6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1721018