Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Upgrade @patternfly/react-console to the latest #104

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Upgrade @patternfly/react-console to the latest #104

merged 2 commits into from
Nov 20, 2018

Conversation

mareklibra
Copy link

@mareklibra mareklibra commented Nov 9, 2018

Upgrade npm dependency to get latest changes in pf-react consoles.

Issues of upgrade:

pf-react changed structure of dist modules (patternfly/patternfly-react@1f3411a).
References need to be fixed in pf-raect first: patternfly/patternfly-react#894

Example:

in 1.4.6: import { EmptyState, Button, noop } from 'patternfly-react';
in 1.5.6: import noop from 'patternfly-react/dist/esm/components/noop/noop';
in sources: import { EmptyState, Button, noop } from 'patternfly-react';

@mareklibra mareklibra changed the title Upgrade.pf react console2 Upgrade @patternfly/react-console to the latest Nov 9, 2018
@mareklibra mareklibra changed the title Upgrade @patternfly/react-console to the latest WIP: Upgrade @patternfly/react-console to the latest Nov 9, 2018
@mareklibra
Copy link
Author

This PR is blocked by issues in pf-react

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2018
Due to breaking changes in patternfly-react build (structure of esm modules),
update is required to have newer @patternfly/react-console working.
To get latest changes in consoles.
@mareklibra mareklibra changed the title WIP: Upgrade @patternfly/react-console to the latest Upgrade @patternfly/react-console to the latest Nov 20, 2018
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2018
@mareklibra
Copy link
Author

pf-react patches were merged so updateing versions here

@mareklibra mareklibra merged commit 2be0ef9 into kubevirt:master Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants