Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ARCHITECTURE.md #285

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

flavio
Copy link
Member

@flavio flavio commented May 28, 2024

Explain how the audit-scanner performs the scan.

Possibile improvements

  1. Instead of doing Namespace auditing sequentially, allow for parallel auditing of namespaces. Expose a flag for that
  2. Inside of a Namespace, keep auditing resources in parallel, but instead of hard coding the number of resources being audited in parallel, expose a flag for that
  3. When auditing a specific resource (like a specific Pod), instead of evaluating each policy sequentially, evaluate them in parallel. Expose a flag for that

@flavio flavio requested a review from a team as a code owner May 28, 2024 13:43
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (038da59) to head (84ece12).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files          11       11           
  Lines         976      976           
=======================================
  Hits          692      692           
  Misses        213      213           
  Partials       71       71           
Flag Coverage Δ
unit-tests 70.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ARCHITECTURE.md Outdated Show resolved Hide resolved
ARCHITECTURE.md Outdated Show resolved Hide resolved
Explain how the audit-scanner performs the scan.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio
Copy link
Member Author

flavio commented May 29, 2024

Merging, I've addressed all the comments. Thanks!

@flavio flavio merged commit b853001 into kubewarden:main May 29, 2024
5 checks passed
@flavio flavio deleted the add-architecture branch May 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants