refactor: use mockery-generated mock, remove gomock mock and hostcaller fake #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
refactor/mockery-mock
branch
from
862e9c5
to
451bc05
Compare
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
fabriziosestito
force-pushed
the
refactor/mockery-mock
branch
from
451bc05
to
6bfef64
Compare
jvanz
approved these changes
Jun 5, 2024
flavio
reviewed
Jun 6, 2024
| @@ -17,4 +17,4 @@ deps: | |||
| go get github.com/golangci/golangci-lint/cmd/golangci-lint | |||
|
|
|||
| generate-mocks: | |||
| docker run --rm -v ${PWD}:/src -w /src golang:1.20-alpine ./hack/generate-mocks.sh | |||
| mockery | |||
There was a problem hiding this comment.
I've seen from the mockery documentation that's it's possible to generate the mocks with go generate. Can we do that as well, the main reason would to not require the mockery binary to be installed on the system
There was a problem hiding this comment.
@flavio go generate requires the binary to be installed, as it just runs the command in the comment. I prefer having the .mockery.yaml configuration since it is easier to read than a golang comment.
There was a problem hiding this comment.
I'm ok with the approach. Also, the Makefile is a bit of a mess.. no phony targets and so. But not needed to fix in this PR.
There was a problem hiding this comment.
@viccuad could you open an issue about the Makefile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generates a new mock with mockery and removes the
gomock(deprecated) generated mock and the hostcaller fake.Updates tests accordingly.