Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opentelemetry otlp integration #85

Merged
merged 2 commits into from Sep 13, 2021

Conversation

flavio
Copy link
Member

@flavio flavio commented Sep 13, 2021

This PR fixes the integration with opentelemetry otlp collector. When we updated the project dependencies we introduced 2 regressions:

  1. The name of the service was not propagated by the otlp collector to other endpoints/collector
  2. opentelemetry was not sending traces in batch mode. This is the recommended way for production deployments, otherwise the performance of the whole application will be affected by trace propagation

Finally, the PR adds a sample configuration file of otlp collector receiving events from policy-server and then sending them to a jaeger endpoint

Add a configuration for the otel-collector that:
  * Receive incoming traces via grpc
  * Forward trace events to a jaeger collector, via grpc
* Ensure the name of the service originating the tracing events is
  properly propagated through by the otlp collector
* Use the batch exported, the simple one has poor performance and is not
  recommended for production usage
@flavio flavio added this to Pending review in Development Sep 13, 2021
Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@flavio flavio merged commit 1f12297 into kubewarden:main Sep 13, 2021
@flavio flavio deleted the fix-opentelemetry-otlp-integration branch September 13, 2021 10:54
@flavio flavio moved this from Pending review to Done in Development Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development
Done (weekly)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants