Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy implementation #2

Merged
merged 18 commits into from Mar 22, 2023
Merged

Policy implementation #2

merged 18 commits into from Mar 22, 2023

Conversation

flavio
Copy link
Member

@flavio flavio commented Mar 7, 2023

This is the code that implements kubewarden/kubewarden-controller#377

TODO

  • write e2e tests
  • update README
  • update metadata.yml
  • update artifact-hub.yml
  • publish changes to Go SDK

These are the changes implementing the core of the policy.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
This policy requires a patched version of the tinygo compiler in order
to be built.

This commit adds the Dockerfile used to build the container image.

Finally, the new Makefile adds support for golinter

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Update the go modules and the vendored copy

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio marked this pull request as draft March 7, 2023 09:29
@flavio flavio self-assigned this Mar 7, 2023
@flavio flavio added this to Pending review in Development Mar 7, 2023
Add proper details to README and policy metadata

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Add e2e files

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Extend the makefile

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Consume the Go SDK from the `context-aware` branch

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio marked this pull request as ready for review March 7, 2023 17:36
@flavio
Copy link
Member Author

flavio commented Mar 7, 2023

@viccuad , @jvanz : this is now ready to be reviewed. The e2e tests are already there, but I think I'll try a different approach to handle them.

In the meantime you can review the other parts of the PR

types.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
validate.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
hack/setup-e2e-env.sh Outdated Show resolved Hide resolved
hack/setup-e2e-env.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Little nits only.

@flavio flavio moved this from Pending review to Blocked in Development Mar 13, 2023
@flavio
Copy link
Member Author

flavio commented Mar 13, 2023

Temporarily moving it back to blocked. Waiting for kubewarden/kwctl#448 to be done

@flavio flavio moved this from Blocked to TODO in Development Mar 17, 2023
Use the replay session feature of kwctl. This allows us to execute the
tests without having a kubernetes cluster running

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Update to latest released version of the Kubewarden Go SDK

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Use the latest set of changes introduced by the new Kubewarden GH action

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio moved this from TODO to Pending review in Development Mar 22, 2023
Automate the release process

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio and others added 3 commits March 22, 2023 10:17
Update the artifacthub and the metadata files

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Co-authored-by: José Guilherme Vanz <1514798+jvanz@users.noreply.github.com>
Signed-off-by: Flavio Castelli <flavio@castelli.me>
Take feedback from review process

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio
Copy link
Member Author

flavio commented Mar 22, 2023

@jvanz, @viccuad: I've updated the policy with all the required bells and whistles. It's not ready for being reviewed again

@viccuad
Copy link
Member

viccuad commented Mar 22, 2023

the CI job failures happen because of undefined VERSION for make artifacthub-pkg.yml (so, same issue as this one).

metadata.yml Outdated Show resolved Hide resolved
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nits, the only issue is the check-artifacthub job failing because of lack of preexisting tag for VERSION. I'm ok merging as it is, once tagged we will never have that problem.

flavio and others added 3 commits March 22, 2023 12:02
Co-authored-by: Víctor Cuadrado Juan <2196685+viccuad@users.noreply.github.com>
Signed-off-by: Flavio Castelli <flavio@castelli.me>
Regenerate the metadata.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Co-authored-by: Víctor Cuadrado Juan <2196685+viccuad@users.noreply.github.com>
Signed-off-by: Flavio Castelli <flavio@castelli.me>
@flavio flavio merged commit 4b268a3 into main Mar 22, 2023
2 of 4 checks passed
Development automation moved this from Pending review to Done (weekly) Mar 22, 2023
@flavio flavio deleted the policy branch March 22, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development
Done (weekly)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants