fix(qrm): use max NUMA allocatable to calculate min-needed NUMAs (#173)

kubewharf · Jul 27, 2023 · c0539e3 · c0539e3
1 parent 085b466
commit c0539e3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/agent/qrm-plugins/memory/dynamicpolicy/state/state.go b/pkg/agent/qrm-plugins/memory/dynamicpolicy/state/state.go
@@ -311,12 +311,17 @@ func (nm NUMANodeMap) BytesPerNUMA() (uint64, error) {
 		return 0, fmt.Errorf("getBytesPerNUMAFromMachineState got nil numaMap")
 	}
 
+	var maxNUMAAllocatable uint64
 	for _, numaState := range nm {
 		if numaState != nil {
-			return numaState.Allocatable, nil
+			maxNUMAAllocatable = general.MaxUInt64(maxNUMAAllocatable, numaState.Allocatable)
 		}
 	}
 
+	if maxNUMAAllocatable > 0 {
+		return maxNUMAAllocatable, nil
+	}
+
 	return 0, fmt.Errorf("getBytesPerNUMAFromMachineState doesn't get valid numaState")
 }