Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deadband for pid controller to avoid hunting #113

Merged
merged 1 commit into from Jun 20, 2023

Conversation

sun-yuliang
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Add deadband for pid controller to avoid hunting during the control process.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@sun-yuliang sun-yuliang added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jun 20, 2023
@sun-yuliang sun-yuliang self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 52.02% and project coverage change: -0.39 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (465acf5) 50.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   51.30%   50.91%   -0.39%     
==========================================
  Files         318      375      +57     
  Lines       32418    36217    +3799     
==========================================
+ Hits        16632    18440    +1808     
- Misses      13840    15650    +1810     
- Partials     1946     2127     +181     
Flag Coverage Δ
unittest 50.91% <52.02%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
...gent/app/options/dynamic/adminqos/adminqos_base.go 54.54% <ø> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.73% <ø> (+5.38%) ⬆️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <0.00%> (ø)
...g/agent/qrm-plugins/network/staticpolicy/policy.go 52.97% <ø> (ø)
pkg/agent/qrm-plugins/network/staticpolicy/util.go 62.14% <ø> (ø)
... and 189 more

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit 4aecc48 into kubewharf:main Jun 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants