Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to full path of general logging #130

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

switch the logging path as full by default

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Jul 5, 2023
@waynepeking348 waynepeking348 self-assigned this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 51.75% and project coverage change: -0.44 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (8b82c9a) 50.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   51.30%   50.87%   -0.44%     
==========================================
  Files         318      387      +69     
  Lines       32418    37015    +4597     
==========================================
+ Hits        16632    18830    +2198     
- Misses      13840    16060    +2220     
- Partials     1946     2125     +179     
Flag Coverage Δ
unittest 50.87% <51.75%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/base/context_fake.go 65.94% <ø> (-4.35%) ⬇️
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 63.63% <ø> (-2.31%) ⬇️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <ø> (ø)
...rm-plugins/memory/dynamicpolicy/state/state_mem.go 74.76% <ø> (+0.79%) ⬆️
... and 198 more

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit 98962c5 into kubewharf:main Jul 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants