Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor adminqos definition list member remove omitempty json flag #132

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

refactor adminqos definition list and map member remove omitempty json flag and fix unit-test

@luomingmeng luomingmeng added this to the v0.3 milestone Jul 6, 2023
@luomingmeng luomingmeng self-assigned this Jul 6, 2023
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Jul 6, 2023
@luomingmeng luomingmeng marked this pull request as ready for review July 6, 2023 02:51
@luomingmeng luomingmeng requested a review from zzzzhhb July 6, 2023 02:51
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 51.86% and project coverage change: -0.74 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (5d34798) 50.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   51.30%   50.57%   -0.74%     
==========================================
  Files         318      387      +69     
  Lines       32418    37015    +4597     
==========================================
+ Hits        16632    18719    +2087     
- Misses      13840    16186    +2346     
- Partials     1946     2110     +164     
Flag Coverage Δ
unittest 50.57% <51.86%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/base/context_fake.go 70.28% <ø> (ø)
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 63.63% <ø> (-2.31%) ⬇️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <ø> (ø)
...rm-plugins/memory/dynamicpolicy/state/state_mem.go 74.76% <ø> (+0.79%) ⬆️
... and 197 more

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jul 6, 2023
@waynepeking348 waynepeking348 merged commit 45ad217 into kubewharf:main Jul 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants