Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs to trim container id in pod spec #175

Merged

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

when fetching metrics, we should trim the container id in pod spec (for malachite interface)

@waynepeking348 waynepeking348 added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Aug 1, 2023
@waynepeking348 waynepeking348 self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.45% ⚠️

Comparison is base (83bce0c) 51.74% compared to head (aab8a4a) 51.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   51.74%   51.30%   -0.45%     
==========================================
  Files         421      421              
  Lines       40641    40666      +25     
==========================================
- Hits        21031    20863     -168     
- Misses      17307    17521     +214     
+ Partials     2303     2282      -21     
Flag Coverage Δ
unittest 51.30% <90.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...metaserver/agent/metric/malachite/client/client.go 100.00% <ø> (ø)
pkg/util/cgroup/common/path.go 85.91% <80.00%> (-2.02%) ⬇️
...server/agent/metric/malachite/client/client_pod.go 80.85% <100.00%> (+6.56%) ⬆️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Aug 1, 2023
@waynepeking348 waynepeking348 merged commit 44e4fd5 into kubewharf:main Aug 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants